fix(cli): make error message more appropriate#1817
Closed
ian-fox wants to merge 1 commit intolacework:mainfrom
Closed
fix(cli): make error message more appropriate#1817ian-fox wants to merge 1 commit intolacework:mainfrom
ian-fox wants to merge 1 commit intolacework:mainfrom
Conversation
PengyuanZhao
approved these changes
Feb 19, 2026
Author
|
@PengyuanZhao is there anything else I need to do for this one? It looks like the CI pipeline is still pending, I think a maintainer needs to approve them. |
Collaborator
|
@ian-fox there is a trailing space in commit message which blocks CI pipeline. |
When using the CLI to make an API request that returns a status code indicating an error, the CLI currently prints an error message of the form `ERROR unable to send the request: <specific error details follow>` That message isn't entirely accurate, as this path is also hit if the error comes from the server - e.g. if the server returns a 4XX or 5XX response. This change makes the message more generic so that it applies even if the error occurred after the request was sent. No issues or tickets to reference because I figured it was easier to just make the pull request.
Author
|
@lokesh-vadlamudi I think it should be fixed now! |
Author
|
I see that there are some failing checks still, but looking at the error messages they don't seem to be related to the change. |
Collaborator
auto-merge was automatically disabled
March 12, 2026 19:07
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When using the CLI to make an API request that returns a status code indicating an error, the CLI currently prints an error message of the form
ERROR unable to send the request: <specific error details follow>That message isn't entirely accurate, as this path is also hit if the error comes from the server - e.g. if the server returns a 4XX or 5XX response.
This change makes the message more generic so that it applies even if the error occurred after the request was sent.
How did you test this change?
No functional changes, so I think the existing test suite should be sufficient.
Issue
No issues or tickets to reference because I figured it was easier to just make the pull request.