Skip to content

Use sns_topic_name instead of sns_topic_arn#168

Merged
leijin-lw merged 1 commit intolacework:mainfrom
lra:patch-1
Feb 4, 2025
Merged

Use sns_topic_name instead of sns_topic_arn#168
leijin-lw merged 1 commit intolacework:mainfrom
lra:patch-1

Conversation

@lra
Copy link
Contributor

@lra lra commented Feb 4, 2025

Summary

The aws_cloudtrail.lacework_cloudtrail resources expects a sns_topic_name.

Terraform will perform the following actions:

  # module.lacework_aws_cloudtrail.aws_cloudtrail.lacework_cloudtrail[0] will be updated in-place
  ~ resource "aws_cloudtrail" "lacework_cloudtrail" {
        id                            = "arn:aws:cloudtrail:us-west-1:REDACTED:trail/lacework-cloudtrail"
        name                          = "lacework-cloudtrail"
      ~ sns_topic_name                = "lacework-ct-sns-7374a5e3" -> "arn:aws:sns:us-west-1:REDACTED:lacework-ct-sns-7374a5e3"
        tags                          = {}
        # (14 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

This changes fixes a drift that constantly tries to set the sns_topic_arn to the sns_topic_name argument.

How did you test this change?

I locally tried this change with a terraform plan:

No changes. Your infrastructure matches the configuration.

Issue

@lra lra requested a review from a team as a code owner February 4, 2025 13:51
@lra lra requested review from jeffreynglw, leijin-lw and lwmobeent and removed request for a team February 4, 2025 13:51
@leijin-lw leijin-lw merged commit 71a7652 into lacework:main Feb 4, 2025
2 of 8 checks passed
@lra lra deleted the patch-1 branch February 5, 2025 15:43
@lra
Copy link
Contributor Author

lra commented Feb 5, 2025

Thanks! Any chance to see this released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants