Skip to content

Conversation

@kirklandnuts
Copy link
Contributor

@kirklandnuts kirklandnuts commented Jul 28, 2025

Summary

We want to update our azurerm and azuread providers to >=4.0 and >=3.0, respectively. See ticket for context.

This required two changes:

  1. azurerm 4.0 made subscription_id a required argument, so our regional modules (global == false) need to now reference the scanning_subscription_id from the global module reference.
  2. azuread changed the expected parsing format of service_principal_id so it now requires a fully qualified id — we resolve this by referencing azuread_service_principal.data_loader[0].id instead of azuread_service_principal.data_loader[0].object_id

How did you test this change?

Successfully deployed an azure awls integration on prod-canary-test.lacework.net - was also able to destroy the integration successfully.

Issue

AWLS2-561

@kirklandnuts kirklandnuts requested review from a team as code owners July 28, 2025 17:19
@kirklandnuts kirklandnuts marked this pull request as draft July 28, 2025 17:19
@kirklandnuts
Copy link
Contributor Author

Hi @PengyuanZhao, I'm having some trouble with terraform-docs.

I ran make terraform-docs and it executed terraform-docs using docker:

$ make terraform-docs
make terraform-docs
scripts/terraform-docs.sh
## terraform-docs not found in PATH, but docker was found
## running terraform-docs in docker
data/README.md updated successfully

The README's md5 hash is 569a72d2967e32579f329917ca5ae9ce, which doesn't match the expected hash generated in the github workflow, 86072e01e369fec29bedb8cb19fdd7d1.

$ md5sum README.md   
569a72d2967e32579f329917ca5ae9ce  README.md

I even tried installing terraform-docs locally and am still having the same result:

$ terraform-docs --version
terraform-docs version v0.17.0 795d369 linux/amd64

$ terraform-docs .        
README.md updated successfully

$ md5sum README.md
569a72d2967e32579f329917ca5ae9ce  README.md

Here's my question: do you know why terraform-docs is generating a README in github workflow that's different from what terraform-docs is generating when I run it locally?

Am I doing something wrong?

@kirklandnuts kirklandnuts force-pushed the feat/upgrade-azure-providers branch from 7c1eb7d to 19fb1c2 Compare July 28, 2025 17:52
@kirklandnuts kirklandnuts marked this pull request as ready for review July 28, 2025 18:16
@kirklandnuts kirklandnuts marked this pull request as draft July 28, 2025 18:17
@kirklandnuts kirklandnuts marked this pull request as ready for review July 28, 2025 19:04
Copy link
Contributor

@PengyuanZhao PengyuanZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lokesh-vadlamudi lokesh-vadlamudi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@kirklandnuts kirklandnuts merged commit a050977 into main Jul 29, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants