-
Notifications
You must be signed in to change notification settings - Fork 2
feat: upgrade azure providers #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @PengyuanZhao, I'm having some trouble with terraform-docs. I ran $ make terraform-docs
make terraform-docs
scripts/terraform-docs.sh
## terraform-docs not found in PATH, but docker was found
## running terraform-docs in docker
data/README.md updated successfullyThe README's md5 hash is $ md5sum README.md
569a72d2967e32579f329917ca5ae9ce README.mdI even tried installing terraform-docs locally and am still having the same result: $ terraform-docs --version
terraform-docs version v0.17.0 795d369 linux/amd64
$ terraform-docs .
README.md updated successfully
$ md5sum README.md
569a72d2967e32579f329917ca5ae9ce README.mdHere's my question: do you know why terraform-docs is generating a README in github workflow that's different from what terraform-docs is generating when I run it locally? Am I doing something wrong? |
7c1eb7d to
19fb1c2
Compare
PengyuanZhao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
lokesh-vadlamudi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :-)
Summary
We want to update our
azurermandazureadproviders to>=4.0and>=3.0, respectively. See ticket for context.This required two changes:
subscription_ida required argument, so our regional modules (global == false) need to now reference thescanning_subscription_idfrom the global module reference.azuread_service_principal.data_loader[0].idinstead ofazuread_service_principal.data_loader[0].object_idHow did you test this change?
Successfully deployed an azure awls integration on prod-canary-test.lacework.net - was also able to destroy the integration successfully.
Issue
AWLS2-561