Remove unused parser version-check methods per review feedback#15
Merged
laeubi merged 2 commits intoissue_4849_mr_jlsfrom Feb 19, 2026
Merged
Conversation
Remove isParsingJava8Plus() (always true, Java 8 is minimum), and remove unused methods: isParsingJava11Plus(), isParsingJava15Plus(), isParsingJava18Plus(), isParsingJava21Plus(), isParsingJava22Plus(). Replace isParsingJava8Plus() call sites with simplified expressions. Co-authored-by: laeubi <1331477+laeubi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address review comments from iloveeclipse
Remove unused parser version-check methods per review feedback
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review comments from @iloveeclipse on PR eclipse-jdt#4856: remove dead code revealed by the fields-to-methods refactor.
isParsingJava8Plus()— always returnstruesince Java 8 is the minimum supported version. Simplify 3 call sites by dropping the redundant check.isParsingJava11Plus(),isParsingJava15Plus(),isParsingJava18Plus(),isParsingJava21Plus(),isParsingJava22Plus()isParsingJava14Plus()— has active callers; reviewer noted full removal belongs in a later PR💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.