Fix HTML5 validation errors in org.eclipse.jdt.doc.isv documentation #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: laeubi <[email protected]>
Co-authored-by: laeubi <[email protected]>
Co-authored-by: laeubi <[email protected]>
Copilot
AI
changed the title
[WIP] Fix HTML validation issues in org.eclipse.jdt.doc.isv
Fix HTML5 validation errors in org.eclipse.jdt.doc.isv documentation
Oct 26, 2025
Copilot finished work on behalf of
laeubi
October 26, 2025 13:40
Co-authored-by: laeubi <[email protected]>
Fixed in commit 24d78a7. Table attributes are now replaced with inline CSS styles instead of being removed:
|
Copilot finished work on behalf of
laeubi
October 26, 2025 13:52
akurtakov
reviewed
Oct 26, 2025
|
|
||
| <p>The following table summarizes the different kinds of Java elements.</p> | ||
| <table border="1"> | ||
| <table style="border: 1px solid"> |
There was a problem hiding this comment.
This is not equivalent change as this style setting will create outer border for the table but not for the cells inline.
There was a problem hiding this comment.
@copilot please look at the comment from @akurtakov above and adjust all files accordingly, also suggest a line that could be used in a prompt to prevent that issue in future request.
Copilot finished work on behalf of
laeubi
October 26, 2025 16:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes HTML validation errors in org.eclipse.jdt.doc.isv documentation files, reducing from 1238 errors to 0 (100% reduction). The remaining validation message is a table structure issue unrelated to HTML5 compliance.
Changes
DOCTYPE modernization (29 files)
<!DOCTYPE html>Charset declarations (29 files)
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">to<meta charset="utf-8">Obsolete elements removed (29 files)
<meta http-equiv="Content-Style-Type">tagscharsetattribute from<link>elementsTable attributes replaced with inline CSS (2 files)
border="1"→style="border: 1px solid"cellspacing="2"→style="border-spacing: 2px"cellpadding="2"→style="padding: 2px"(applied to td/th elements)width="100%"→style="width: 100%"width="140"→style="width: 140px"(on th elements)valign="top"→style="vertical-align: top"(on tr/td elements)URL encoding (10 instances)
[]→%5B%5Din method signatures)Example
Before:
After:
Files Modified
29 files in
eclipse.platform.common/bundles/org.eclipse.jdt.doc.isv/guide/*.htmOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.