Skip to content

Fix vpDetectorAprilTag configuration using JSON#1931

Merged
fspindle merged 2 commits intolagadic:masterfrom
rolalaro:fix_apriltag_json_conf
Mar 17, 2026
Merged

Fix vpDetectorAprilTag configuration using JSON#1931
fspindle merged 2 commits intolagadic:masterfrom
rolalaro:fix_apriltag_json_conf

Conversation

@rolalaro
Copy link
Contributor

Forgot to set the attribute m_tagFamily when loading configuration from a JSON file.

@codecov
Copy link

codecov bot commented Mar 16, 2026

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.36%. Comparing base (41a3fb2) to head (5fcc8a5).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
modules/detection/src/tag/vpDetectorAprilTag.cpp 33.33% 1 Missing and 3 partials ⚠️
...ction/include/visp3/detection/vpDetectorAprilTag.h 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1931      +/-   ##
==========================================
- Coverage   48.41%   48.36%   -0.06%     
==========================================
  Files         532      532              
  Lines       69328    69334       +6     
  Branches    32424    32440      +16     
==========================================
- Hits        33566    33530      -36     
- Misses      31515    31519       +4     
- Partials     4247     4285      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@fspindle fspindle merged commit 48c5dc2 into lagadic:master Mar 17, 2026
87 checks passed
@rolalaro rolalaro deleted the fix_apriltag_json_conf branch March 17, 2026 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants