Skip to content

Conversation

bywang56
Copy link
Collaborator

@bywang56 bywang56 commented Apr 8, 2025

Problem

Should notice customer when tools accessing files/dirs outside of workspace

Solution

Add validation step when accessing files/dirs outside of workspace using fsRead or listDirectories tools.

Tests

Tests both tools, verified button shows up and workflow continues to finish after "accept"


  • Treat all work as PUBLIC. Private feature/x branches will not be squash-merged at release time.
  • Your code changes must meet the guidelines in CONTRIBUTING.md.
  • License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bywang56 bywang56 force-pushed the feature/agentic-chat branch from af6fb86 to 921d2f7 Compare April 8, 2025 21:24
@bywang56 bywang56 changed the title Add validation for fsRead and listDir tool Fix: Add validation for fsRead and listDir tool Apr 8, 2025
@bywang56 bywang56 changed the title Fix: Add validation for fsRead and listDir tool fix: Add validation for fsRead and listDir tool Apr 8, 2025
@bywang56
Copy link
Collaborator Author

bywang56 commented Apr 8, 2025

/retrybuilds

@bywang56 bywang56 changed the title fix: Add validation for fsRead and listDir tool feat(chat): Add validation for fsRead and listDir tool Apr 8, 2025
@bywang56 bywang56 force-pushed the feature/agentic-chat branch from 921d2f7 to 6416551 Compare April 8, 2025 21:43
@bywang56 bywang56 changed the title feat(chat): Add validation for fsRead and listDir tool feat(chat): Add user validation for tools Apr 8, 2025
@bywang56 bywang56 merged commit b2e2128 into laileni-aws:feature/mega Apr 8, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant