Fixing PSA key slot exhaustion problem#411
Open
ElsaLopez133 wants to merge 3 commits intolake-rs:mainfrom
Open
Fixing PSA key slot exhaustion problem#411ElsaLopez133 wants to merge 3 commits intolake-rs:mainfrom
ElsaLopez133 wants to merge 3 commits intolake-rs:mainfrom
Conversation
Member
|
We're
|
chrysn
reviewed
Mar 5, 2026
| key_agreement::raw_key_agreement(alg, my_key, &peer_public_key, &mut output_buffer) | ||
| .unwrap(); | ||
|
|
||
| unsafe { key_management::destroy(my_key).unwrap() }; |
Member
There was a problem hiding this comment.
Suggested change
| unsafe { key_management::destroy(my_key).unwrap() }; | |
| // SAFETY: The function demands that the Id is not used while destroyed. | |
| // We did not hand out the Id `my_key` in the last few lines, so we can destroy it. | |
| unsafe { key_management::destroy(my_key).unwrap() }; |
(Also, I feel reaffirmed in doing embedded-cal rather than fixing psa_crypto…)
WilliamTakeshi
approved these changes
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each p256_ecdh call imports a key into a PSA key slot, and if those slots aren't being freed after use, it runs out and PSA returns InsufficientMemory.