Skip to content

Value Prefix Whitespace #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 28, 2024
Merged

Value Prefix Whitespace #6

merged 8 commits into from
Sep 28, 2024

Conversation

@shehabgamin
Copy link

@shehabgamin shehabgamin commented Sep 28, 2024 •
edited
Loading

linhr
linhr reviewed Sep 28, 2024
View reviewed changes
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11082640616

Details

  • 21 of 30 (70.0%) changed or added relevant lines in 1 file are covered.
  • 1085 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.4%) to 88.907%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/tokenizer.rs 21 30 70.0%
Files with Coverage Reduction New Missed Lines %
src/tokenizer.rs 117 87.51%
src/parser/mod.rs 968 81.96%
Totals Coverage Status
Change from base Build 11033928132: -0.4%
Covered Lines: 27091
Relevant Lines: 30471
💛 - Coveralls

@shehabgamin shehabgamin marked this pull request as ready for review September 28, 2024 09:57
@shehabgamin shehabgamin mentioned this pull request Sep 28, 2024
Merged
@shehabgamin shehabgamin linked an issue Sep 28, 2024 that may be closed by this pull request
Value Prefixes Followed By Whitespace Not Parsed Correctly lakehq/sail#209
Closed
@shehabgamin shehabgamin merged commit 0908ddb into dev Sep 28, 2024
20 checks passed
@shehabgamin shehabgamin deleted the value-prefixes-whitespace branch September 28, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@linhr linhr linhr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Value Prefixes Followed By Whitespace Not Parsed Correctly

3 participants

@shehabgamin @coveralls @linhr