fix: resolve build errors#481
Merged
lakinduakash merged 1 commit intolakinduakash:masterfrom Jun 7, 2025
Merged
Conversation
Contributor
Integral-Tech
commented
Jun 7, 2025
b6ab5e9 to
a3fce4b
Compare
Closed
|
This PR breaks build with GCC 9 (for example gcc -c -o ../build/ui.o ui/ui.c `pkg-config --cflags gtk+-3.0`
ui/ui.c: In function ‘stopHp’:
ui/ui.c:134:21: error: parameter name omitted
134 | static void *stopHp(void *) {
| ^~~~~~
ui/ui.c: In function ‘init_running_info’:
ui/ui.c:713:25: error: parameter name omitted
713 | void* init_running_info(void *){
| ^~~~~~Here's a workaround diff --git a/src/ui/ui.c b/src/ui/ui.c
index 0af37de..906c555 100644
--- a/src/ui/ui.c
+++ b/src/ui/ui.c
@@ -131,7 +131,7 @@ static ConfigValues configValues;
-static void *stopHp(void *) {
+static void *stopHp(void *unused) {
if(running_info[0]!=NULL){
gtk_label_set_label(label_status,"Stopping ...");
start_pb_pulse();
@@ -710,7 +710,7 @@ void clear_running_info(){
running_info[0]=NULL;
}
-void* init_running_info(void *){
+void* init_running_info(void *unused){
clear_running_info();
lock_all_views(TRUE); |
Owner
|
Can you please make a PR to fix this. Thanks |
|
See #489 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.