[pull] main from open-telemetry:main #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=80&v=4){kind=small}
* update setup_cmake* scripts to verify the versions installed * set cmake minimum version to 3.14. Fix issues found in tested with the min version * update cmake install action workflow to test specific cmake versions including the min version. update the conan stable file to test older versions of benchmark and prometheus-cpp * fix format issue * run the windows cmake min test with 3.16 due to failing otlp file tests with 3.14 * update changelog * add back explict policies including CMP0091 that was introduced in cmake 3.15. Set the windows job to cmake 3.15 * Address review feedback. Always set the new curl and zlib version variables. Remove legacy PROTOBUF_FOUND. * add comment about cmake 3.15 as minimum for windows builds. Fix cmake error on protobuf version warning. Remove bzip2 as dependency for conan builds * set cmake version expliclity in the workflow file for each cmake install test job. Add newline to the end of setup_cmake.ps1 * use config search mode for gtest for install tests * update install md file with note on the cmake minimum version and recommend cmake 3.15+ on windows. * fix markdownlint error * Update install.md with explict message about the known windows ci test failures with cmake 3.14 * comments from review feedback * update install.md
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 89.56% 89.56%
=======================================
Files 210 210
Lines 6502 6502
=======================================
Hits 5823 5823
Misses 679 679 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )