Skip to content

Conversation

@pull
Copy link

@pull pull bot commented Apr 25, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

step-security-bot and others added 3 commits April 25, 2025 19:03
Signed-off-by: StepSecurity Bot <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Co-authored-by: Marc Alff <[email protected]>
* add base2 expo histo aggregation

* add base2 expo histo, test, benchmark

* add prom, otlp exporter and example

* add ostream exporter and example

* update vscode launch

* run tools/format.sh

* add grpc exporter target switch for unix sockets

* Added ConvertExponentialHistogramMetric unit test

* Update the osstream_metric_test with ExponentialHistogram

* update CHANGELOG.md

* markdown lint

* Comment non-used function add missing includes

* add metrics dependency to otlp exporters test build

* run format

* remove unused function definition

* Added empty line in the end of a test file and removed comments

* Fix windows build errors

* fix iwyu warnings

* add comment to trigger pr update

* fix additional iwyu warnings

* Fix iwyu warning

* Fix include order in base2_exponential_histogram_aggregation.h

* Add kcumulative and kdelta aggregation temporality test with collect calls for base2 histogram aggregation

* add prelim bucketing checks

* Tested the exp2 constructor with point data

* Fix missing include in sync histogram test

* move diff and merge to use union of all buckets approach

* make get a const method

* update base2 expo hiso diff test

* add base2 expo histo test with sync storage collect

* uncomment examples

* format

* use static_cast

* fix comments

* update changelog

* Fix comments and errors in the pipeline

* Update sdk/src/metrics/aggregation/base2_exponential_histogram_aggregation.cc

Co-authored-by: Tom Tan <[email protected]>

* remove unused code

* set max_buckets minimum to 2

* Revert otlp grpc client changes

Propose change in follow up PR

* [wip] make buckets unique ptr

* refactor unique_ptr for buckets with deep copies

* format

* update otlp serialization test with unique ptr

* format

* Small pipeline fixes

* iwyu fix

* remove boundary and format

---------

Co-authored-by: Ruslan Nigmatullin <[email protected]>
Co-authored-by: Felipe C. Dos Santos <[email protected]>
Co-authored-by: Tom Tan <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
Co-authored-by: Felipe C. Dos Santos <[email protected]>
Signed-off-by: StepSecurity Bot <[email protected]>
Co-authored-by: Lalit Kumar Bhasin <[email protected]>
@pull pull bot added the ⤵️ pull label Apr 25, 2025
@pull pull bot merged commit 7801cd9 into lalitb:main Apr 25, 2025
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 92.04893% with 26 lines in your changes missing coverage. Please review.

Project coverage is 89.67%. Comparing base (f6d16d2) to head (7801cd9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...egation/base2_exponential_histogram_aggregation.cc 90.64% 22 Missing ⚠️
...etry/sdk/metrics/aggregation/default_aggregation.h 50.00% 2 Missing ⚠️
exporters/ostream/src/metric_exporter.cc 95.46% 1 Missing ⚠️
...nclude/opentelemetry/sdk/metrics/data/point_data.h 95.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #380      +/-   ##
==========================================
+ Coverage   89.57%   89.67%   +0.11%     
==========================================
  Files         210      211       +1     
  Lines        6505     6832     +327     
==========================================
+ Hits         5826     6126     +300     
- Misses        679      706      +27     
Files with missing lines Coverage Δ
exporters/ostream/test/ostream_metric_test.cc 100.00% <100.00%> (ø)
...pentelemetry/sdk/metrics/aggregation/aggregation.h 100.00% <ø> (ø)
...metry/sdk/metrics/aggregation/aggregation_config.h 100.00% <ø> (ø)
...e/opentelemetry/sdk/metrics/data/circular_buffer.h 100.00% <ø> (ø)
sdk/src/metrics/data/circular_buffer.cc 100.00% <100.00%> (ø)
exporters/ostream/src/metric_exporter.cc 91.55% <95.46%> (+0.65%) ⬆️
...nclude/opentelemetry/sdk/metrics/data/point_data.h 96.16% <95.00%> (-3.84%) ⬇️
...etry/sdk/metrics/aggregation/default_aggregation.h 79.02% <50.00%> (-1.50%) ⬇️
...egation/base2_exponential_histogram_aggregation.cc 90.64% <90.64%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants