Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@ Increment the:

## [Unreleased]

* [BUILD] Error out when building DLL without MSVC
[#3438](https://github.com/open-telemetry/opentelemetry-cpp/pull/3438)

* [Metrics SDK] Use nostd::function_ref in AttributesHashMap
[#3393](https://github.com/open-telemetry/opentelemetry-cpp/pull/3393)

Expand Down
2 changes: 1 addition & 1 deletion ext/src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,6 @@ if(WITH_HTTP_CLIENT_CURL)
add_subdirectory(http/client/curl)
endif()

if(MSVC AND DEFINED OPENTELEMETRY_BUILD_DLL)
if(DEFINED OPENTELEMETRY_BUILD_DLL)
add_subdirectory(dll)
endif()
6 changes: 6 additions & 0 deletions ext/src/dll/CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
# Copyright The OpenTelemetry Authors
# SPDX-License-Identifier: Apache-2.0

if(NOT MSVC)
message(
FATAL_ERROR
"The OpenTelemetry C++ SDK for Windows DLL is only supported on MSVC.")
endif()

set(OPENTELEMETRY_EXPORT_DEF
"${CMAKE_CURRENT_BINARY_DIR}/opentelemetry_cpp.def")

Expand Down
Loading