refactor: improve error handling in createTransaction

[lcmohsen]

Handle and throw createTransaction error.

Summary by CodeRabbit

Release Notes

• Bug Fixes
  • Improved error handling for payment transactions with more informative error messages when transaction failures occur.

[coderabbitai]

Walkthrough

This PR refines error handling and transaction management in the Braintree payment provider's core module. Changes include improved error propagation with specific error messages, enhanced try/catch blocks in transaction creation paths, simplified cart retrieval logic with consistent early returns, and standardized string literal formatting across the file.

Changes

Cohort / File(s)

Change Summary

Error Handling & Transaction Flow Refinements plugins/braintree-payment/src/providers/payment-braintree/src/core/braintree-base.ts

Enhanced error handling in authorizePayment and createTransaction methods; improved error message propagation using specific error context instead of generic strings; added try/catch wrapping for transaction creation; improved saleResponse.transaction.gatewayRejectionReason handling; simplified cart retrieval logic with consistent early returns; standardized string literals to single quotes; normalized formatting consistency across webhook, refund, and error paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Error propagation logic: Verify that specific error messages and context are correctly propagated in authorizePayment and createTransaction flows
• Transaction failure handling: Ensure gatewayRejectionReason fallback behavior (?? 'Unknown error') is correct and doesn't mask important errors
• Cart retrieval safety: Confirm early return patterns in cart retrieval don't skip necessary processing
• Error wrapping consistency: Check that wrapped errors with additional context (e.g., transactionId) maintain sufficient debugging information

Possibly related PRs

• fix: braintree refund #26: Modifies the same braintree-base.ts file with related error handling and refund/transaction flow improvements

Suggested reviewers

• antony-lambdacurry

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The pull request title "refactor: improve error handling in createTransaction" is clearly and specifically related to the main changes in the changeset. The PR objectives explicitly state "Handle and throw createTransaction error," which directly aligns with the title's focus on error handling improvements in the createTransaction method. The raw summary confirms this is a primary focus, with multiple sections detailing enhanced error handling in createTransaction, including try/catch wrapping, specific error message propagation, and context preservation. While the changeset includes supporting improvements like formatting adjustments and code simplifications, the title accurately captures the core objective and is specific enough that a teammate reviewing the history would understand the primary intent.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch mohsen/360t-898-braintree-fraud-detection-cases-are-not-covered

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f80de76 and 87ad0e2.

📒 Files selected for processing (1)

• plugins/braintree-payment/src/providers/payment-braintree/src/core/braintree-base.ts (9 hunks)

🔇 Additional comments (3)

plugins/braintree-payment/src/providers/payment-braintree/src/core/braintree-base.ts (3)

373-376: Improved error message propagation.

Good improvement! Propagating the specific error message instead of a generic string provides better debugging information while maintaining a safe fallback.

---

637-642: Cleaner error message handling.

Excellent improvement! Using gatewayRejectionReason directly instead of JSON stringifying the response provides much cleaner and more actionable error messages.

---

644-653: Enhanced error context with transaction ID.

Good addition! Including the transaction ID in the error context significantly improves debugging and troubleshooting capabilities, especially when investigating payment sync failures.

[coderabbitai]

🛠️ Refactor suggestion | 🟠 Major

Remove redundant try-catch block.

The inner try-catch block that immediately rethrows adds no value since the outer try-catch at line 335 already handles all errors from this function, including those from createTransaction.

Apply this diff to simplify the error handling:

       if (!transaction) {
-        try {
-          transaction = await this.createTransaction({
-            input,
-          });
-        } catch (error) {
-          throw error;
-        }
+        transaction = await this.createTransaction({
+          input,
+        });
       }

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	if (!transaction) {
	try {
	transaction = await this.createTransaction({
	input,
	});
	} catch (error) {
	throw error;
	}
	}
	if (!transaction) {
	transaction = await this.createTransaction({
	input,
	});
	}

🤖 Prompt for AI Agents

In
plugins/braintree-payment/src/providers/payment-braintree/src/core/braintree-base.ts
around lines 344 to 352, remove the redundant inner try-catch that simply
rethrows the caught error; instead directly await this.createTransaction({ input
}) to assign transaction so the outer try-catch at ~line 335 handles any errors,
keeping behavior identical but simplifying the code and eliminating unnecessary
exception wrapping.