-
Notifications
You must be signed in to change notification settings - Fork 0
Add storage utils tests + extend todo-context hydration/persistence tests #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d todo-context tests for hydration + persistence Co-authored-by: Jake Ruesink <[email protected]>
STA-10 [Testing] Add storage + hydration tests (utils + todo-context)
Requested by: Jake Ruesink Summary Base branch for PR: codegen-bot/persist-todos-localstorage-STA-2-1754688724 Code context
Testing notes
Acceptance criteria
References |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
…' into codegen/sta-10-testing-add-storage-hydration-tests-utils-todo-context
…' of github.com:lambda-curry/react-router-starter into codegen/sta-10-testing-add-storage-hydration-tests-utils-todo-context
…e handling and cleanup This update refines the todo-context tests by introducing a consistent localStorage polyfill for Node environments, ensuring reliable test execution. It also improves the cleanup logic in the tests to maintain a clean state between runs. Additionally, minor formatting adjustments are made for better readability.
This update simplifies the todo context reducer by consolidating conditional expressions for better readability. Additionally, it enhances the test suite by allowing real localStorage usage in tests, ensuring more accurate persistence behavior during testing. Minor formatting adjustments are also made for consistency.
This update refines the loadFromStorage function by consolidating its signatures for improved clarity and consistency. The changes enhance type safety while maintaining backward compatibility with optional validation logic.
…s storage mocking
…test file exclusions This change adds type definitions for Vitest and Testing Library to the todo-app's TypeScript configuration. Additionally, it removes the exclusion of test files from the build process, allowing for better integration with testing tools.
073512b
into
codegen-bot/persist-todos-localstorage-STA-2-1754688724
Requested by: Jake Ruesink
Summary
Adds missing unit tests for storage utilities and extends todo-context tests to validate hydration and persistence flows for the new localStorage integration.
What
Notes
Compliance with org/repo rules
Links
Requested by: Jake Ruesink
💻 View my work • 👤 Initiated by
Jake Ruesink• About Codegen⛔ Remove Codegen from PR • 🚫 Ban action checks