Add support for Ntex #482
Open
Add support for Ntex #482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add ntex support
maud/src/lib.rs
Outdated
Comment on lines
374
to
378
| if self.0.is_empty() { | ||
| Poll::Ready(None) | ||
| } else { | ||
| Poll::Ready(Some(Ok(Bytes::from(mem::take(&mut self.0).into_bytes())))) | ||
| } |
There was a problem hiding this comment.
Can we forward to the implementation for String?
Suggested change
| if self.0.is_empty() { | |
| Poll::Ready(None) | |
| } else { | |
| Poll::Ready(Some(Ok(Bytes::from(mem::take(&mut self.0).into_bytes())))) | |
| } | |
| self.0.poll_next_chunk(context) |
There was a problem hiding this comment.
The implementation follows ntex impl MessageBody for String, avoiding unnecessary allocations and one-shot consumption of the body, performance wise it's the best.
| use crate::PreEscaped; | ||
| use alloc::{rc::Rc, string::String}; | ||
|
|
||
| impl MessageBody for PreEscaped<String> { |
There was a problem hiding this comment.
Is implementing MessageBody necessary here, given that we implement Responder directly?
There was a problem hiding this comment.
The MessageBody adds flexibility, allowing maud to be used anywhere the body it's accepted, not only in the Responder.
Co-authored-by: Chris Wong <[email protected]>
|
I'm suggesting to call the String implementation, instead of duplicating it.
…On Mon, Sep 29, 2025, 01:52 David Miguel ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In maud/src/lib.rs
<#482 (comment)>:
> + if self.0.is_empty() {
+ Poll::Ready(None)
+ } else {
+ Poll::Ready(Some(Ok(Bytes::from(mem::take(&mut self.0).into_bytes()))))
+ }
The implementation follows ntex impl MessageBody for String
<https://github.com/ntex-rs/ntex/blob/6d1aa23d929c485710643ae78abbf3f03d4b7514/ntex-http/src/body.rs#L383>,
avoiding unnecessary allocations and one-shot consumption of the body,
performance wise it's the best.
—
Reply to this email directly, view it on GitHub
<#482 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAL73Y3NVJQAAVKWA6NVS2L3U773XAVCNFSM6AAAAACG2FFTS6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTENZXGEYTSMBUGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
dvdmgl
commented
Sep 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the Ntex framework.