-
Notifications
You must be signed in to change notification settings - Fork 216
Unify deps makefile target #2211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Benchmark Results for unmodified programs 🚀
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2211 +/- ##
=======================================
Coverage 96.69% 96.69%
=======================================
Files 104 104
Lines 44023 44023
=======================================
Hits 42567 42567
Misses 1456 1456 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JulianGCalderon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
gabrielbosio
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I would also remove the make deps-macos mention in the README
Unify deps makefile target
Description
Tested this on mac and linux by doing
make depsand thenmake tests. It worked on both.Closes #2097
Checklist