Skip to content

fix: error mapping for fee_provision in excess_balance hint #2236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JulianGCalderon merged 4 commits into from
Oct 27, 2025
Merged

fix: error mapping for fee_provision in excess_balance hint #2236

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b44acf5
fix: error mapping for fee_provision in excess_balance hint
radik878 Oct 18, 2025
acf17dc
Update CHANGELOG.md
radik878 Oct 20, 2025
afb6fd1
Merge branch 'main' into fix/excess-balance-fee-error
radik878 Oct 20, 2025
cc23c18
Merge branch 'main' into fix/excess-balance-fee-error
JulianGCalderon Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

#### Upcoming Changes

* fix: error mapping for fee_provision in excess_balance hint [#2236](https://github.com/lambdaclass/cairo-vm/pull/2236)

* fix: Remove unused dependency getrandom for cairo1-run, and serde_json for wasm-demo-cairo1 [#2238](https://github.com/lambdaclass/cairo-vm/pull/2238)

* chore: Unify deps makefile target [#2211](https://github.com/lambdaclass/cairo-vm/pull/2211)
Expand Down
6 changes: 4 additions & 2 deletions vm/src/hint_processor/builtin_hint_processor/excess_balance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -376,10 +376,12 @@ pub fn excess_balance_hint(
.checked_add(unrealized_funding_pnl)
.and_then(|sum| sum.checked_add(token_assets_value_d))
.ok_or_else(|| HintError::ExcessBalanceCalculationFailed("account_value".into()))?;
let fee_provision = fees
let fee = fees
.get(&account)
.and_then(|fee| abs_balance_value.checked_mul(*fee))
.ok_or_else(|| HintError::ExcessBalanceKeyError("fees".into()))?;
let fee_provision = abs_balance_value
.checked_mul(*fee)
.ok_or_else(|| HintError::ExcessBalanceCalculationFailed("fee_provision".into()))?;
let margin_requirement = position_margin
.checked_add(fee_provision)
.ok_or_else(|| HintError::ExcessBalanceCalculationFailed("margin_requirements".into()))?;
Expand Down
Loading