Assorted hints2 #305
Open
Assorted hints2 #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #305 +/- ##
==========================================
- Coverage 56.11% 56.10% -0.01%
==========================================
Files 48 48
Lines 6239 6402 +163
==========================================
+ Hits 3501 3592 +91
- Misses 2390 2444 +54
- Partials 348 366 +18
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
fmoletta
reviewed
Oct 2, 2023
| execScopes.AssignOrUpdateVariable("value", value) | ||
|
|
||
| val := memory.NewMaybeRelocatableFelt(flag) | ||
| idsData.Insert("flag", val, vm) |
fmoletta
reviewed
Oct 2, 2023
| } | ||
| y := yUnpacked.Pack86() | ||
|
|
||
| res, _ := math_utils.DivMod(&x1, &y, &p) |
fmoletta
reviewed
Oct 2, 2023
|
|
||
| // Generic methods for all types | ||
| func limbsFromVarName(nLimbs int, name string, ids IdsManager, vm *VirtualMachine) ([]Felt, error) { | ||
| func LimbsFromVarName(nLimbs int, name string, ids IdsManager, vm *VirtualMachine) ([]Felt, error) { |
Contributor
There was a problem hiding this comment.
Don't expose it, create a BigInt5 wrapper instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.