-
Notifications
You must be signed in to change notification settings - Fork 162
fix(l1): bump kurtosis version to 1.15.2 to fix assertoor ci #6198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Docker Engine v29 raised the minimum API version to 1.44. Kurtosis 1.10.2 ships a client that only supports API 1.43, causing assertoor CI jobs to fail.
🤖 Kimi Code ReviewReview SummaryThis PR updates the Kurtosis version used in the GitHub Actions workflow from 1.10.2 to 1.15.2. Security & Correctness
Recommendations
The change itself is minimal and appears safe. The workflow will validate the new version through the test execution. Automated review by Kimi (Moonshot AI) · custom prompt |
🤖 Codex Code ReviewLooks good. This change only bumps the Kurtosis version used in the CI workflow; no Rust/EVM/consensus code is affected. Notes:
No further issues found. Automated review by OpenAI Codex · custom prompt |
🤖 Claude Code ReviewNow let me provide the code review: PR Review: chore(ci): bump kurtosis version to 1.15.2SummaryThis is a straightforward dependency version bump for Kurtosis in the CI workflow. The change is necessary to maintain compatibility with Docker Engine v29, which raised the minimum API version to 1.44. Review Findings✅ Positive Aspects
📝 Observations & Recommendations1. Version jump magnitude
2. Consistency check # Check for other Kurtosis version references
grep -r "kurtosis_version" .github/workflows/3. Testing considerations
🔍 Code QualityFile: kurtosis_version: "1.15.2"✅ The change is correct and follows the existing format (quoted string). Security Considerations✅ No security concerns. This is a version bump of a development/testing tool used in CI, not production code. Ethereum-Specific ConsiderationsN/A - This change affects CI infrastructure, not Ethereum execution client logic. VerdictLGTM with monitoring recommendation ✅ The change is necessary and correctly implemented. The code looks good. Recommend:
Sources:
Automated review by Claude (Anthropic) · custom prompt |
Greptile OverviewGreptile SummaryBumped Kurtosis from 1.10.2 to 1.15.2 in the assertoor CI workflow to resolve Docker Engine v29 compatibility issues. Docker Engine v29 requires Docker API version 1.44 minimum, while Kurtosis 1.10.2 only supports API 1.43, causing CI failures. Key Changes:
Issues Found:
Confidence Score: 4/5
|
| Filename | Overview |
|---|---|
| .github/workflows/pr-main_l1.yaml | Updated Kurtosis from 1.10.2 to 1.15.2 for Docker Engine v29 compatibility, but .github/actions/snapsync-run/action.yml still references 1.10.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
a663e67 to
1a2cab7
Compare
Recently this started happening https://github.com/lambdaclass/ethrex/actions/runs/21960414777/job/63436623972?pr=6009
Summary
Test plan