Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/snapsync-run/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ runs:
uses: ethpandaops/kurtosis-assertoor-github-action@v1
with:
enclave_name: ethrex-assertoor-${{ inputs.network }}-${{ inputs.cl_type }}
kurtosis_version: 1.10.2
kurtosis_version: 1.15.2
ethereum_package_url: github.com/ethpandaops/ethereum-package
ethereum_package_branch: 82e5a7178138d892c0c31c3839c89d53ffd42d9a
ethereum_package_args: .github/config/assertoor/network_params.generated.yaml
Expand Down
28 changes: 24 additions & 4 deletions .github/scripts/check-hive-results.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,20 +57,39 @@ failed_logs_root="${results_dir}/failed_logs"
rm -rf "${failed_logs_root}"
mkdir -p "${failed_logs_root}"

# Known-flaky tests to ignore (substring match against test case name).
# These are hive framework issues, not ethrex bugs.
KNOWN_FLAKY_TESTS=(
"Invalid Missing Ancestor Syncing ReOrg, Timestamp, EmptyTxs=False, CanonicalReOrg=False, Invalid P8"
"Invalid Missing Ancestor Syncing ReOrg, Timestamp, EmptyTxs=False, CanonicalReOrg=True, Invalid P8"
)

# Build a jq filter that excludes known-flaky tests.
flaky_filter='true'
for pattern in "${KNOWN_FLAKY_TESTS[@]}"; do
flaky_filter="${flaky_filter} and (.name | contains(\"${pattern}\") | not)"
done

for json_file in "${json_files[@]}"; do
if [[ "${json_file}" == *"hive.json" ]]; then
continue
fi

suite_name="$(jq -r '.name // empty' "${json_file}")"
failed_cases="$(jq '[.testCases[]? | select(.summaryResult.pass != true)] | length' "${json_file}")"
failed_cases="$(jq '[.testCases[]? | select(.summaryResult.pass != true) | select('"${flaky_filter}"')] | length' "${json_file}")"

skipped_flaky="$(jq '[.testCases[]? | select(.summaryResult.pass != true) | select(('"${flaky_filter}"') | not)] | length' "${json_file}")"
if [ "${skipped_flaky}" -gt 0 ]; then
echo "Ignoring ${skipped_flaky} known-flaky test(s) in ${suite_name:-$(basename "${json_file}")}"
fi

if [ "${failed_cases}" -gt 0 ]; then
echo "Detected ${failed_cases} failing test case(s) in ${suite_name:-$(basename "${json_file}")}"
failure_list="$(
jq -r '
.testCases[]?
| select(.summaryResult.pass != true)
| select('"${flaky_filter}"')
| . as $case
| ($case.summaryResult // {}) as $summary
| ($summary.message // $summary.reason // $summary.error // "") as $message
Expand Down Expand Up @@ -124,9 +143,9 @@ for json_file in "${json_files[@]}"; do
[
.simLog?,
.testDetailsLog?,
(.testCases[]? | select(.summaryResult.pass != true) | .clientInfo? | to_entries? // [] | map(.value.logFile? // empty) | .[]),
(.testCases[]? | select(.summaryResult.pass != true) | .summaryResult.logFile?),
(.testCases[]? | select(.summaryResult.pass != true) | .logFile?)
(.testCases[]? | select(.summaryResult.pass != true) | select('"${flaky_filter}"') | .clientInfo? | to_entries? // [] | map(.value.logFile? // empty) | .[]),
(.testCases[]? | select(.summaryResult.pass != true) | select('"${flaky_filter}"') | .summaryResult.logFile?),
(.testCases[]? | select(.summaryResult.pass != true) | select('"${flaky_filter}"') | .logFile?)
]
| map(select(. != null and . != ""))
| unique
Expand Down Expand Up @@ -196,6 +215,7 @@ for json_file in "${json_files[@]}"; do
.testCases
| to_entries[]
| select(.value.summaryResult.pass != true)
| select(.value | '"${flaky_filter}"')
| . as $case_entry
| ($case_entry.value.clientInfo? // {}) | to_entries[]
| [
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr-main_l1.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ jobs:
uses: ethpandaops/kurtosis-assertoor-github-action@v1
with:
enclave_name: ${{ matrix.enclave_name }}
kurtosis_version: "1.10.2"
kurtosis_version: "1.15.2"
ethereum_package_url: "github.com/ethpandaops/ethereum-package"
ethereum_package_branch: "82e5a7178138d892c0c31c3839c89d53ffd42d9a"
ethereum_package_args: ${{ matrix.ethereum_package_args }}
Expand Down Expand Up @@ -289,7 +289,7 @@ jobs:
uses: ethpandaops/[email protected]
with:
hive_repository: ethereum/hive
hive_version: 7709e5892146c793307da072e1593f48039a7e4b
hive_version: 0ee187ce394720a5902c135324ac7de4240cbb37
simulator: ${{ matrix.simulation }}
client: ethrex
client_config: ${{ steps.client-config.outputs.config }}
Expand Down