Skip to content

Conversation

@juan518munoz
Copy link
Contributor

@juan518munoz juan518munoz commented Jul 7, 2025

Remove spawn_listener and spawn_broadcast_listener functions in favour of spawned's helper functions for its GenServers.

Note: this PR should not be merged until related spawned changes are available on a release.

Closes #3387

@github-actions
Copy link

github-actions bot commented Jul 7, 2025

Lines of code report

Total lines added: 0
Total lines removed: 22
Total lines changed: 22

Detailed view
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 689   | -22  |
+--------------------------------------------------------+-------+------+

@mpaulucci mpaulucci changed the title Replace rlpx listener funcitons with spawned implementation Replace rlpx listener functions with spawned implementation Jul 7, 2025
@juan518munoz
Copy link
Contributor Author

Verfified by running hive tests:

make run-hive-debug SIMULATION=devp2p TEST_PATTERN="*"

And also by running three nodes at once:
image

Copy link
Contributor

@ElFantasma ElFantasma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Nice 🕶️

@juan518munoz juan518munoz marked this pull request as ready for review July 15, 2025 15:23
@juan518munoz juan518munoz requested a review from a team as a code owner July 15, 2025 15:23
@juan518munoz juan518munoz changed the title Replace rlpx listener functions with spawned implementation refactor(l1): replace rlpx listener functions with spawned implementation Jul 15, 2025
@github-actions github-actions bot added the L1 Ethereum client label Jul 15, 2025
@juan518munoz juan518munoz added this pull request to the merge queue Jul 18, 2025
Merged via the queue into main with commit a94a05c Jul 18, 2025
43 of 48 checks passed
@juan518munoz juan518munoz deleted the add_spawned_listener branch July 18, 2025 20:53
pedrobergamini pushed a commit to pedrobergamini/ethrex that referenced this pull request Aug 24, 2025
…tation (lambdaclass#3504)

Remove `spawn_listener` and `spawn_broadcast_listener` functions in
favour of `spawned`'s helper functions for its GenServers.

Note: this PR should not be merged until [related spawned
changes](lambdaclass/spawned#20) are available
on a release.

Closes lambdaclass#3387
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Use Stream listener mechanism from spawned, once implemented

6 participants