Skip to content

Conversation

@tomip01
Copy link
Contributor

@tomip01 tomip01 commented Jul 31, 2025

Motivation

Currently we have in our Cargo.toml:

spawned-concurrency = "0.2.1"
spawned-rt = "0.2.1"

And our Cargo.lock has this versions.
However, external crates, like rex (see this), that depend on ethrex fail to compile it because they attempt to build it using the newer version 0.2.2.

I went for using the newer version instead of pining the older version.

Description

  • Change spawned-* to 0.2.2
  • Add InitResult on the init methods for the GenServer trait

@github-actions github-actions bot added the L2 Rollup client label Jul 31, 2025
@tomip01 tomip01 changed the title fix(l2,l1): fix spawned 0.2.2 fix(l2,l1): bump spawned to 0.2.2 Jul 31, 2025
@tomip01 tomip01 marked this pull request as ready for review July 31, 2025 16:02
Copilot AI review requested due to automatic review settings July 31, 2025 16:02
@tomip01 tomip01 requested a review from a team as a code owner July 31, 2025 16:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the spawned concurrency library versions from 0.2.1 to 0.2.2 to resolve compilation issues with external crates depending on ethrex. The key change is adapting to the updated GenServer trait that now requires returning InitResult<Self> instead of Self from init methods.

  • Bump spawned-concurrency and spawned-rt versions to 0.2.2
  • Update GenServer init method signatures to return InitResult
  • Wrap existing self returns with InitResult::Success

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
Cargo.toml Updates spawned library versions from 0.2.1 to 0.2.2
crates/networking/p2p/rlpx/connection/server.rs Adds InitResult import and updates init method return type
crates/l2/sequencer/l1_watcher.rs Updates GenServer init method to return InitResult::Success
crates/l2/monitor/app.rs Updates GenServer init method to return InitResult::Success

@github-actions
Copy link

github-actions bot commented Jul 31, 2025

Lines of code report

Total lines added: 5
Total lines removed: 0
Total lines changed: 5

Detailed view
+--------------------------------------------------------+-------+------+
| File                                                   | Lines | Diff |
+--------------------------------------------------------+-------+------+
| ethrex/crates/l2/sequencer/l1_watcher.rs               | 339   | +2   |
+--------------------------------------------------------+-------+------+
| ethrex/crates/networking/p2p/rlpx/connection/server.rs | 796   | +3   |
+--------------------------------------------------------+-------+------+

@tomip01 tomip01 moved this to In Review in ethrex_l2 Jul 31, 2025
@tomip01
Copy link
Contributor Author

tomip01 commented Aug 4, 2025

Closes in favor of #3840

@tomip01 tomip01 closed this Aug 4, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l2 Aug 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L2 Rollup client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants