-
Notifications
You must be signed in to change notification settings - Fork 153
fix(l2,l1): bump spawned to 0.2.2 #3909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the spawned concurrency library versions from 0.2.1 to 0.2.2 to resolve compilation issues with external crates depending on ethrex. The key change is adapting to the updated GenServer trait that now requires returning InitResult<Self> instead of Self from init methods.
- Bump spawned-concurrency and spawned-rt versions to 0.2.2
- Update GenServer init method signatures to return InitResult
- Wrap existing self returns with InitResult::Success
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Cargo.toml | Updates spawned library versions from 0.2.1 to 0.2.2 |
| crates/networking/p2p/rlpx/connection/server.rs | Adds InitResult import and updates init method return type |
| crates/l2/sequencer/l1_watcher.rs | Updates GenServer init method to return InitResult::Success |
| crates/l2/monitor/app.rs | Updates GenServer init method to return InitResult::Success |
Lines of code reportTotal lines added: Detailed view |
|
Closes in favor of #3840 |
Motivation
Currently we have in our
Cargo.toml:And our
Cargo.lockhas this versions.However, external crates, like
rex(see this), that depend onethrexfail to compile it because they attempt to build it using the newer version0.2.2.I went for using the newer version instead of pining the older version.
Description
spawned-*to0.2.2InitResulton theinitmethods for theGenServertrait