perf(l1): avoid unnecesary work on bloom and keep a per layer bloom #5176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping a per layer bloom helps avoiding rehashing every time a bloom rebuild happens. This is because the bloom merge method uses the u64 hash keys directly instead of rehashing the value of type T. This is an improved version of #5175 where in addition to that we keep a per layer bloom to avoid extra hash work.
Lines of code reportTotal lines added: Detailed view |
Oppen
reviewed
Nov 4, 2025
Oppen
reviewed
Nov 4, 2025
| /// Per layer bloom filter, None if the size was exceeded (exceedingly rare). | ||
| /// Having a bloom per layer avoids the cost of rehashing each key every time we rebuild the globam bloom, | ||
| /// since merge simply uses the u64 hashed keys instead of rehashing. | ||
| bloom: Option<qfilter::Filter>, |
There was a problem hiding this comment.
Don't change it right now, but I think we should start referring to this as "query filter", as we're not necessarily relying on the Bloom implementation (approximate query filter is the "generic" name, but too long).
Oppen
reviewed
Nov 4, 2025
Benchmark Block Execution Results Comparison Against Main
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping a per layer bloom helps avoiding rehashing every time a bloom rebuild happens.
This is because the bloom merge method uses the u64 hash keys directly instead of rehashing the value of type T.
This is an improved version of #5175 where in addition to that we keep a per layer bloom to avoid extra hash work.