Skip to content

feat(l1,l2): setting avx2 flags for compilation and adding features asm to crates #5189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Nov 5, 2025
+19 −10
Merged

feat(l1,l2): setting avx2 flags for compilation and adding features asm to crates #5189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
50922a4
rustflags adding avx2 flags to compilation
pablodeymo Nov 4, 2025
f1fd04f
uniformization of sha3 with workspace crate
pablodeymo Nov 4, 2025
1c0b5a6
remove unused import tracing::error
pablodeymo Nov 4, 2025
548546d
remove sha2_backend flag due to the invalid flag
pablodeymo Nov 4, 2025
a0da8ac
changing target-cpu to x86-64-v3
pablodeymo Nov 4, 2025
f5d5780
adding target features
pablodeymo Nov 4, 2025
33dd8e0
target-feature fixed
pablodeymo Nov 4, 2025
bf8efc3
ssse3 to target_feature
pablodeymo Nov 4, 2025
da2d5a9
adding features asm to crates
pablodeymo Nov 4, 2025
b40399d
Merge branch 'main' into avx2
pablodeymo Nov 5, 2025
522a371
Merge branch 'avx2' into avx2-with-asm-features
pablodeymo Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,5 @@
[target.x86_64-unknown-linux-gnu]
rustflags = ["-Ctarget-cpu=x86-64-v2"]
rustflags = [
"-Ctarget-cpu=x86-64-v3",
"-Ctarget-feature=+avx2,+sse2,+ssse3,+sse4.1,+sse4.2,+bmi1,+lzcnt,+pclmulqdq",
Copy link
Contributor

@azteca1998 azteca1998 Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The target-feature should already be enabled for the x86-64-v3 target CPU.
Are they explicitly there for any reason in particular?

Copy link
Contributor Author

@pablodeymo pablodeymo Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we found some crates are checking for the specific feature not included when we set target-cpu

]
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ hex-literal = "0.4.1"
crc32fast = "1.4.2"
lazy_static = "1.5.0"
sha2 = "0.10.8"
sha3 = "0.10.8"
sha3 = { version = "0.10.8", features = ["asm"] }
tokio-util = { version = "0.7.15", features = ["rt"] }
jsonwebtoken = "9.3.0"
rand = "0.8.5"
Expand Down
2 changes: 1 addition & 1 deletion crates/blockchain/payload.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ use crate::{
};

use thiserror::Error;
use tracing::{debug, error, warn};
use tracing::{debug, warn};

#[derive(Debug)]
pub struct PayloadBuildTask {
Expand Down
5 changes: 4 additions & 1 deletion crates/common/crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@ path = "./lib.rs"

[dependencies]
# TODO(#1102): Move to Lambdaworks in the future
c-kzg = { version = "2.1.1", optional = true }
c-kzg = { version = "2.1.1", default-features = false, optional = true, features = [
"ethereum_kzg_settings",
"std",
] }
kzg-rs.workspace = true

thiserror.workspace = true
Expand Down
2 changes: 1 addition & 1 deletion crates/networking/p2p/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ rocksdb = { workspace = true, optional = true }
prometheus = "0.14.0"

tokio-stream = "0.1.17"
sha3 = "0.10.8"
sha3.workspace = true

serde_json = "1.0.117"

Expand Down
9 changes: 6 additions & 3 deletions crates/networking/rpc/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ethrex-common.workspace = true
ethrex-storage.workspace = true
ethrex-vm.workspace = true
ethrex-blockchain.workspace = true
ethrex-p2p = {workspace = true, features = ["test-utils"]}
ethrex-p2p = { workspace = true, features = ["test-utils"] }
ethrex-rlp.workspace = true
ethrex-trie.workspace = true
ethrex-storage-rollup = { workspace = true, optional = true }
Expand All @@ -32,9 +32,12 @@ jsonwebtoken.workspace = true
rand.workspace = true
tokio-util = { workspace = true, features = ["codec"] }
reqwest.workspace = true
sha3 = "0.10.8"
sha3.workspace = true
sha2.workspace = true
jemalloc_pprof = { version = "0.8.0", optional = true, features = ["flamegraph", "symbolize"] }
jemalloc_pprof = { version = "0.8.0", optional = true, features = [
"flamegraph",
"symbolize",
] }
spawned-rt.workspace = true
spawned-concurrency.workspace = true

Expand Down
4 changes: 2 additions & 2 deletions crates/vm/levm/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ thiserror.workspace = true
serde = { workspace = true, features = ["derive", "rc"] }
serde_json.workspace = true

sha3 = "0.10.8"
sha3.workspace = true
datatest-stable = "0.2.9"
walkdir = "2.5.0"
secp256k1.workspace = true
Expand All @@ -39,7 +39,7 @@ bls12_381 = { git = "https://github.com/lambdaclass/bls12_381", branch = "expose
] }
ark-bn254 = "0.5.0"
ark-ec = "0.5.0"
ark-ff = "0.5.0"
ark-ff = { version = "0.5.0", features = ["asm"] }
strum = { version = "0.27.1", features = ["derive"] }
k256 = "0.13.4"
substrate-bn = { version = "0.6.0", optional = true }
Expand Down
Loading