Skip to content

Conversation

@ManuelBilbao
Copy link
Contributor

Motivation

Changes to docs are slow because of waiting pointless tests.

Description

Avoid running tests if the changes are only in docs/. According to GH docs:

If any path names do not match patterns in paths-ignore, even if some path names match the patterns, the workflow will run.
So we are guaranteed that the tests are going to run if there is at least one non-docs change

Resolves #3323

Copilot AI review requested due to automatic review settings January 6, 2026 19:34
@ManuelBilbao ManuelBilbao requested a review from a team as a code owner January 6, 2026 19:34
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Jan 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes CI workflow execution by adding paths-ignore filters to skip running tests when changes are exclusively in the docs/ directory, reducing unnecessary CI time for documentation-only updates.

Key Changes

  • Added paths-ignore: ["docs/**"] to both push and pull_request triggers across L1 and L2 workflow files
  • Applied to 6 workflow files covering L1, L2, L2 Dev, L2 Prover, L2 TDX Build, and SP1 Backend workflows

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/pr-main_l2_tdx_build.yaml Added docs path ignore filters to both push and pull request triggers
.github/workflows/pr-main_l2_prover.yaml Added docs path ignore filters to both push and pull request triggers
.github/workflows/pr-main_l2.yaml Added docs path ignore filters to both push and pull request triggers
.github/workflows/pr-main_l1_l2_dev.yaml Added docs path ignore filters to both push and pull request triggers
.github/workflows/pr-main_l1.yaml Added docs path ignore filters to both push and pull request triggers
.github/workflows/main_prover.yaml Added docs path ignore filter to push trigger only, creating inconsistency with existing pull request path filter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Jan 6, 2026
@ManuelBilbao ManuelBilbao enabled auto-merge January 6, 2026 19:57
@ManuelBilbao ManuelBilbao added this pull request to the merge queue Jan 6, 2026
Merged via the queue into main with commit c0dd265 Jan 6, 2026
63 checks passed
@ManuelBilbao ManuelBilbao deleted the dont_run_ci_on_docs_changes branch January 6, 2026 21:24
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jan 6, 2026
@github-project-automation github-project-automation bot moved this to Done in ethrex_l2 Jan 6, 2026
github-merge-queue bot pushed a commit that referenced this pull request Jan 7, 2026
**Motivation**

<!-- Why does this pull request exist? What are its goals? -->
Our GH setup requires certain "Checks" (GHA jobs titles) to pass to
merge a PR. Changes introduced in #5750 make docs-only PRs to not
trigger some checks, blocking those PRs.

**Description**

<!-- A clear and concise general description of the changes this PR
introduces -->
Restore trigger on required checks and run the jobs conditionally on
paths changed. According to [GH
docs](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks):
> If, however, a job within a workflow is skipped due to a conditional,
it will report its status as "Success".

<!-- Link to issues: Resolves #111, Resolves #222 -->

---------

Co-authored-by: Tomás Paradelo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

CI: Disable tests on /docs changes

4 participants