-
Notifications
You must be signed in to change notification settings - Fork 146
ci(l1,l2): avoid running CI tests on docs-only changes #5750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes CI workflow execution by adding paths-ignore filters to skip running tests when changes are exclusively in the docs/ directory, reducing unnecessary CI time for documentation-only updates.
Key Changes
- Added
paths-ignore: ["docs/**"]to bothpushandpull_requesttriggers across L1 and L2 workflow files - Applied to 6 workflow files covering L1, L2, L2 Dev, L2 Prover, L2 TDX Build, and SP1 Backend workflows
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pr-main_l2_tdx_build.yaml |
Added docs path ignore filters to both push and pull request triggers |
.github/workflows/pr-main_l2_prover.yaml |
Added docs path ignore filters to both push and pull request triggers |
.github/workflows/pr-main_l2.yaml |
Added docs path ignore filters to both push and pull request triggers |
.github/workflows/pr-main_l1_l2_dev.yaml |
Added docs path ignore filters to both push and pull request triggers |
.github/workflows/pr-main_l1.yaml |
Added docs path ignore filters to both push and pull request triggers |
.github/workflows/main_prover.yaml |
Added docs path ignore filter to push trigger only, creating inconsistency with existing pull request path filter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
**Motivation** <!-- Why does this pull request exist? What are its goals? --> Our GH setup requires certain "Checks" (GHA jobs titles) to pass to merge a PR. Changes introduced in #5750 make docs-only PRs to not trigger some checks, blocking those PRs. **Description** <!-- A clear and concise general description of the changes this PR introduces --> Restore trigger on required checks and run the jobs conditionally on paths changed. According to [GH docs](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/troubleshooting-required-status-checks#handling-skipped-but-required-checks): > If, however, a job within a workflow is skipped due to a conditional, it will report its status as "Success". <!-- Link to issues: Resolves #111, Resolves #222 --> --------- Co-authored-by: Tomás Paradelo <[email protected]>
Motivation
Changes to docs are slow because of waiting pointless tests.
Description
Avoid running tests if the changes are only in
docs/. According to GH docs:Resolves #3323