Skip to content

Conversation

@jrchatruc
Copy link
Collaborator

@jrchatruc jrchatruc commented Jan 7, 2026

Motivation

Substate backups are no longer used by the vm; they can be removed.

Description

Checklist

  • Updated STORE_SCHEMA_VERSION (crates/storage/lib.rs) if the PR includes breaking changes to the Store requiring a re-sync.

@jrchatruc jrchatruc requested a review from a team as a code owner January 7, 2026 16:02
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Jan 7, 2026
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Lines of code report

Total lines added: 0
Total lines removed: 2
Total lines changed: 2

Detailed view
+---------------------------------+-------+------+
| File                            | Lines | Diff |
+---------------------------------+-------+------+
| ethrex/crates/vm/levm/src/vm.rs | 462   | -2   |
+---------------------------------+-------+------+

@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Benchmark Results Comparison

Benchmark Results: Push

Command Mean [s] Min [s] Max [s] Relative
main_revm_Push 291.8 ± 3.0 289.0 297.3 1.00
main_levm_Push 303.5 ± 3.1 300.3 309.4 1.04 ± 0.02
pr_revm_Push 331.4 ± 118.9 290.3 669.7 1.14 ± 0.41
Detailed Results

Benchmark Results: BubbleSort

Command Mean [s] Min [s] Max [s] Relative
main_revm_BubbleSort 2.991 ± 0.022 2.960 3.039 1.00
main_levm_BubbleSort 3.065 ± 0.034 3.038 3.157 1.02 ± 0.01
pr_revm_BubbleSort 2.999 ± 0.032 2.962 3.068 1.00 ± 0.01
pr_levm_BubbleSort 3.091 ± 0.017 3.068 3.119 1.03 ± 0.01

Benchmark Results: ERC20Approval

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Approval 986.6 ± 4.3 981.4 996.8 1.00
main_levm_ERC20Approval 1104.7 ± 25.4 1083.9 1154.3 1.12 ± 0.03
pr_revm_ERC20Approval 994.8 ± 9.3 978.4 1008.7 1.01 ± 0.01
pr_levm_ERC20Approval 1084.7 ± 6.1 1075.9 1094.9 1.10 ± 0.01

Benchmark Results: ERC20Mint

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Mint 132.0 ± 0.9 130.7 133.2 1.00
main_levm_ERC20Mint 164.6 ± 1.7 162.8 168.2 1.25 ± 0.01
pr_revm_ERC20Mint 132.8 ± 1.5 130.6 135.2 1.01 ± 0.01
pr_levm_ERC20Mint 163.3 ± 1.5 161.9 166.8 1.24 ± 0.01

Benchmark Results: ERC20Transfer

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ERC20Transfer 234.0 ± 2.1 231.0 238.1 1.00 ± 0.01
main_levm_ERC20Transfer 273.2 ± 2.6 270.5 277.8 1.17 ± 0.01
pr_revm_ERC20Transfer 233.4 ± 1.3 231.4 234.9 1.00
pr_levm_ERC20Transfer 273.2 ± 2.3 269.9 278.1 1.17 ± 0.01

Benchmark Results: Factorial

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Factorial 225.3 ± 0.8 224.2 226.5 1.00 ± 0.01
main_levm_Factorial 271.9 ± 3.2 268.9 277.3 1.21 ± 0.02
pr_revm_Factorial 225.2 ± 3.1 222.9 233.6 1.00
pr_levm_Factorial 272.7 ± 7.3 267.3 292.4 1.21 ± 0.04

Benchmark Results: FactorialRecursive

Command Mean [s] Min [s] Max [s] Relative
main_revm_FactorialRecursive 1.621 ± 0.023 1.582 1.655 1.00
main_levm_FactorialRecursive 8.556 ± 0.092 8.414 8.730 5.28 ± 0.09
pr_revm_FactorialRecursive 1.647 ± 0.032 1.594 1.685 1.02 ± 0.02
pr_levm_FactorialRecursive 8.698 ± 0.091 8.581 8.905 5.37 ± 0.10

Benchmark Results: Fibonacci

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Fibonacci 205.4 ± 0.9 203.4 206.5 1.01 ± 0.01
main_levm_Fibonacci 262.4 ± 2.5 257.0 266.3 1.28 ± 0.02
pr_revm_Fibonacci 204.3 ± 1.7 200.7 206.6 1.00
pr_levm_Fibonacci 264.2 ± 3.1 258.8 269.1 1.29 ± 0.02

Benchmark Results: FibonacciRecursive

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_FibonacciRecursive 848.7 ± 13.5 827.0 869.5 1.15 ± 0.06
main_levm_FibonacciRecursive 741.0 ± 15.3 698.5 752.6 1.00 ± 0.05
pr_revm_FibonacciRecursive 850.4 ± 8.6 838.8 861.8 1.15 ± 0.05
pr_levm_FibonacciRecursive 740.3 ± 34.4 684.9 797.6 1.00

Benchmark Results: ManyHashes

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_ManyHashes 8.9 ± 0.1 8.8 9.0 1.01 ± 0.01
main_levm_ManyHashes 9.6 ± 0.1 9.5 9.8 1.09 ± 0.02
pr_revm_ManyHashes 8.8 ± 0.1 8.7 9.0 1.00
pr_levm_ManyHashes 9.5 ± 0.1 9.4 9.7 1.08 ± 0.02

Benchmark Results: MstoreBench

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_MstoreBench 260.7 ± 2.1 258.3 264.1 1.08 ± 0.01
main_levm_MstoreBench 251.1 ± 32.0 238.5 342.1 1.04 ± 0.13
pr_revm_MstoreBench 264.5 ± 6.1 258.9 276.0 1.09 ± 0.03
pr_levm_MstoreBench 241.8 ± 2.1 239.3 246.1 1.00

Benchmark Results: Push

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_Push 291.8 ± 3.0 289.0 297.3 1.00
main_levm_Push 303.5 ± 3.1 300.3 309.4 1.04 ± 0.02
pr_revm_Push 331.4 ± 118.9 290.3 669.7 1.14 ± 0.41
pr_levm_Push 310.0 ± 4.7 306.8 322.6 1.06 ± 0.02

Benchmark Results: SstoreBench_no_opt

Command Mean [ms] Min [ms] Max [ms] Relative
main_revm_SstoreBench_no_opt 165.1 ± 4.8 159.6 172.5 1.83 ± 0.07
main_levm_SstoreBench_no_opt 90.4 ± 1.8 87.8 93.1 1.00 ± 0.03
pr_revm_SstoreBench_no_opt 167.8 ± 3.6 159.5 171.7 1.86 ± 0.06
pr_levm_SstoreBench_no_opt 90.1 ± 2.3 87.7 93.5 1.00

@github-project-automation github-project-automation bot moved this to In Review in ethrex_l1 Jan 7, 2026
@iovoid iovoid added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit 12aeffc Jan 7, 2026
67 checks passed
@iovoid iovoid deleted the remove-unused-substate-backups branch January 7, 2026 18:24
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jan 7, 2026
@github-project-automation github-project-automation bot moved this to Done in ethrex_l2 Jan 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants