-
Notifications
You must be signed in to change notification settings - Fork 154
feat(l1): run daily snapsync checks with trie validations (debug-assertions) #5768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for running daily snapsync checks with debug assertions enabled to catch potential bugs during state validation. The main changes enable building Docker images with custom Cargo profiles and configure the workflow to use the release-with-debug-assertions profile by default.
Key Changes:
- Added
release-with-debug-assertionsCargo profile that inherits release optimizations while enabling debug assertions - Modified Dockerfile to support custom build profiles via BUILD_FLAGS argument
- Updated daily snapsync workflow to build locally with debug assertions instead of using pre-built images
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Cargo.toml | Adds new release-with-debug-assertions profile definition |
| Dockerfile | Implements logic to handle custom build profiles and copy binaries from the correct target directory |
| .github/workflows/daily_snapsync.yaml | Adds build profile selection and passes it to the snapsync action |
| .github/actions/snapsync-run/action.yml | Implements local Docker build with custom profile support |
| docs/developers/ci/daily_snapsync.md | Documents the debug assertions feature and workflow trigger options (also fixes spelling) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
We want to make sure that the snapsyncs running in loop, not just finish but their state is validated
Description
This PR acomplish 2 things:
debug-assertionseasily available for docker