Skip to content

Conversation

@rodrigo-o
Copy link
Collaborator

@rodrigo-o rodrigo-o commented Jan 7, 2026

Motivation

We want to make sure that the snapsyncs running in loop, not just finish but their state is validated

Description

This PR acomplish 2 things:

  • It makes debug-assertions easily available for docker
  • It change how the daily snapsyncs work, building locally instead of using the main image and running with debug-assertions
  • timeouts are now longer

@rodrigo-o rodrigo-o changed the title Add validation to daily snapsync checks feat(l1): run daily snapsync checks with trie validations (debug-assertions) Jan 7, 2026
@github-actions github-actions bot added the L1 Ethereum client label Jan 7, 2026
@rodrigo-o rodrigo-o marked this pull request as ready for review January 9, 2026 16:57
@rodrigo-o rodrigo-o requested a review from a team as a code owner January 9, 2026 16:57
Copilot AI review requested due to automatic review settings January 9, 2026 16:57
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Jan 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for running daily snapsync checks with debug assertions enabled to catch potential bugs during state validation. The main changes enable building Docker images with custom Cargo profiles and configure the workflow to use the release-with-debug-assertions profile by default.

Key Changes:

  • Added release-with-debug-assertions Cargo profile that inherits release optimizations while enabling debug assertions
  • Modified Dockerfile to support custom build profiles via BUILD_FLAGS argument
  • Updated daily snapsync workflow to build locally with debug assertions instead of using pre-built images

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Adds new release-with-debug-assertions profile definition
Dockerfile Implements logic to handle custom build profiles and copy binaries from the correct target directory
.github/workflows/daily_snapsync.yaml Adds build profile selection and passes it to the snapsync action
.github/actions/snapsync-run/action.yml Implements local Docker build with custom profile support
docs/developers/ci/daily_snapsync.md Documents the debug assertions feature and workflow trigger options (also fixes spelling)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rodrigo-o rodrigo-o added this pull request to the merge queue Jan 14, 2026
Merged via the queue into main with commit dea0eb0 Jan 14, 2026
56 checks passed
@rodrigo-o rodrigo-o deleted the add-validation-to-daily-snapsync-checks branch January 14, 2026 19:50
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Jan 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants