Skip to content

Conversation

@gap-editor
Copy link

Motivation

Description

Checklist

  • Updated STORE_SCHEMA_VERSION (crates/storage/lib.rs) if the PR includes breaking changes to the Store requiring a re-sync.

Closes #issue_number

@gap-editor gap-editor requested a review from a team as a code owner February 10, 2026 18:46
@greptile-apps
Copy link

greptile-apps bot commented Feb 10, 2026

Greptile Overview

Greptile Summary

This PR corrects a misspelled RPC error variant (UnsuportedForkUnsupportedFork) across the networking RPC crate, including Engine API handlers (blobs/fork choice/payload), the eth-config handler, the central error-kind mapping, and the JSON-RPC error metadata conversion.

The change standardizes the variant name and corresponding get_error_kind label, while keeping the underlying JSON-RPC error code (-38005) and message format ("Unsupported fork: ...") consistent via RpcErrorMetadata.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk.
  • Changes are a mechanical rename of an internal Rust error enum variant plus corresponding match arms/tests; no behavior changes beyond the variant name and error-kind label, and no remaining references to the old name were found.
  • No files require special attention

Important Files Changed

Filename Overview
crates/networking/rpc/engine/blobs.rs Renames RpcErr variant usage from UnsuportedFork to UnsupportedFork, and updates the associated test assertion.
crates/networking/rpc/engine/fork_choice.rs Updates fork-choice handlers to return RpcErr::UnsupportedFork instead of the misspelled variant in multiple validation paths.
crates/networking/rpc/engine/payload.rs Replaces RpcErr::UnsuportedFork with RpcErr::UnsupportedFork across payload validation/dispatch for engine API versions.
crates/networking/rpc/eth/client.rs Renames the fork gate error from UnsuportedFork to UnsupportedFork in the eth-config handler.
crates/networking/rpc/rpc.rs Updates RPC error kind mapping to reflect the renamed UnsupportedFork variant and string.
crates/networking/rpc/utils.rs Renames the RpcErr variant and its JSON-RPC metadata mapping from UnsuportedFork to UnsupportedFork (error message/code unchanged).

Sequence Diagram

sequenceDiagram
    participant H as RPC handler
    participant U as RpcErr (utils)
    participant R as Rpc RPC layer
    participant M as RpcErrorMetadata

    H->>U: return Err(RpcErr::UnsupportedFork(ctx))
    U->>M: From<RpcErr>::from(UnsupportedFork)
    M-->>R: code=-38005, message="Unsupported fork: ..."
    R-->>H: get_error_kind(err) == "UnsupportedFork"
    H-->>R: JSON-RPC error response
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants