refactor: move blob operations to blobs module #1404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanSerra
added
the
refactor
mpaulucci
approved these changes
Mar 27, 2025
rodrigo-o
reviewed
Mar 27, 2025
rodrigo-o
reviewed
Mar 27, 2025
rodrigo-o
reviewed
Mar 27, 2025
rodrigo-o
reviewed
Mar 27, 2025
rodrigo-o
approved these changes
Mar 28, 2025
Collaborator
rodrigo-o
left a comment
rodrigo-o
left a comment
There was a problem hiding this comment.
Looking good, just left some minor comments!
rodrigo-o
approved these changes
Apr 1, 2025
Comment on lines
+14
to
+16
| Application.fetch_env!(:lambda_ethereum_consensus, ChainSpec) | ||
| |> Keyword.put(:config, MainnetConfig) | ||
| |> then(&Application.put_env(:lambda_ethereum_consensus, ChainSpec, &1)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The CI was failing due to the latest version of
protoc-gen-gorequiring go>=1.22 the go version is bumped in this PRMotivation
Description
Move all blob related functions from
/beacon/pending_blocks.exto/store/blobs.exCloses #1128