feat: electra slashing, proposer_index & compute_sync_committees changes #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeanSerra
changed the title
rodrigo-o
approved these changes
Apr 8, 2025
Comment on lines
+35
to
+42
| on_exit(fn -> | ||
| Application.put_env( | ||
| :lambda_ethereum_consensus, | ||
| EngineApi, | ||
| original_engine_api_config | ||
| ) | ||
| end) | ||
|
|
Co-authored-by: Rodrigo Oliveri <[email protected]>
LeanSerra
changed the title
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
…ges (#1417) Co-authored-by: Rodrigo Oliveri <[email protected]>
rodrigo-o
added a commit
that referenced
this pull request
Apr 25, 2025
…ges (#1417) Co-authored-by: Rodrigo Oliveri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fix spec tests related to slashings
Description
electra/random.exswere failing with "proposer index is incorrect", implemented the changes tocompute_proposer_indexfrom here. The tests from random are still failing with "expected withdrawals don't match the state withdrawals in length" but this fixed 19 other testscompute_sync_committeesfrom hereFixed spec tests