Crate release workflows #25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juan518munoz
commented
Jul 11, 2025
| override: true | ||
|
|
||
| - name: Publish Crate | ||
| run: cargo publish --package spawned-concurrency --token ${{ secrets.CRATES_IO_TOKEN }} |
Contributor
Author
There was a problem hiding this comment.
We need to set a CRATES_IO_TOKEN
juan518munoz
commented
Jul 11, 2025
concurrency/Cargo.toml
Outdated
| version = "0.1.0" | ||
| edition = "2021" | ||
| description = "Spawned Concurrency" | ||
| license = "MIT" |
Contributor
Author
There was a problem hiding this comment.
Same license as we are using for the project repository.
Contributor
There was a problem hiding this comment.
You can refer to the workspace components reliably by using version.workspace = true and the like. It's a good idea to do that for all but name and description.
juan518munoz
commented
Jul 11, 2025
| license = "MIT" | ||
|
|
||
| [dependencies] | ||
| spawned-rt = { workspace = true } |
Contributor
Author
There was a problem hiding this comment.
This needs to change, we need to import from crates.io instead of locally, as it's forbidden to publish with a workspace dependency.
fedacking
reviewed
Jul 15, 2025
rt/Cargo.toml
Outdated
| version = "0.1.0" | ||
| edition = "2021" | ||
| description = "Spawned Runtime" | ||
| version = { workspace = true } |
Contributor
There was a problem hiding this comment.
It's a matter of taste, but I prefer this format
Suggested change
| version = { workspace = true } | |
| version.workspace = true |
Contributor
Author
There was a problem hiding this comment.
Me too, didn't know it was possible, I've changed it
fedacking
approved these changes
Jul 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify workspace to add CI jobs capable of releasing to crates.io when requested:
spawned-rtand another forspawned-concurrency.package.versionspecified in toml.