feat!: unify GenServer self and state #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedacking
reviewed
Jul 21, 2025
ElFantasma
reviewed
Jul 22, 2025
| const TIMEOUT_DURATION: Duration = Duration::from_millis(100); | ||
|
|
||
| #[derive(Default)] | ||
| #[derive(Debug, Default, Clone)] |
Collaborator
There was a problem hiding this comment.
Default is no longer needed, right?
ElFantasma
reviewed
Jul 22, 2025
|
|
||
| impl GenServer for SomeTask { | ||
| type CallMsg = SomeTaskCallMsg; | ||
| type CastMsg = (); |
Collaborator
There was a problem hiding this comment.
Not part of this PR, but maybe we can move all these () to Unused 👉 👈?
fedacking
approved these changes
Jul 22, 2025
github-merge-queue bot
pushed a commit
to lambdaclass/ethrex
that referenced
this pull request
Jul 23, 2025
**Motivation** Update Spawned to accomodate new Actor interface. **Description** Since [spawned `0.2.0`](lambdaclass/spawned#35) the state and GenServer is "the same".
pedrobergamini
pushed a commit
to pedrobergamini/ethrex
that referenced
this pull request
Aug 24, 2025
**Motivation** Update Spawned to accomodate new Actor interface. **Description** Since [spawned `0.2.0`](lambdaclass/spawned#35) the state and GenServer is "the same".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the state parameter of the
GenServertrait to useselfinstead. This reduces the number of types required to add a newGenServer, but imposes more constraints on the wholeGenServer(before we had two "states": theGenServerimplementor, withSyncconstraint; and theGenServer::Statetype, withCloneconstraint, now we only have the second one).