Remove GenServer clone on message reception #42
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GenServers were cloned before callinghandle_castandhandle_callto support a "rollback" functionality if the callback failed on error.As a result:
GenServers with a large state and with heavy message traffic.GenServers to implementClone.GenServeron errors, instead of rolling back.GenServercould consist of pointers to external structures (eg. anArc<Mutex<Store>>) that would suffer modifications during the callback execution and won't rollback on error.So this removes the cloning of the state on each message, also removes the requirement to implement
Cloneon everyGenServer, and also, it borrowsselffor message callbacks instead of transferring ownership, making the use a bit more flexible (no need to return a "new_state" on each callback call).This last change breaks backwards compatibility. Code using this library will need to modify a bit the implemented
GenServers