Generate state_dump even on failure #215
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the execution module to always generate a state_dump, even if the transaction fails to execute.
To do this, I created a new function
execute_and_process_txthat wrapsexecute_tx, and processes the result of the transaction, that is:Also, we were returning
Result<TransactionExecution>, whereTransactionExecutionalso contains aResult, I unified both results into a singleResult<TransactionExecution, whereTransactionExecutionnow doesn't containResult. This allows us to handle the error case more easily.