Skip to content

Add support for standalone true, false and null types#149

Merged
Ocramius merged 1 commit intolaminas:4.8.xfrom
IonBazan:feature/php8.2-types
Nov 18, 2022
Merged

Add support for standalone true, false and null types#149
Ocramius merged 1 commit intolaminas:4.8.xfrom
IonBazan:feature/php8.2-types

Conversation

@IonBazan
Copy link
Contributor

@IonBazan IonBazan commented Nov 2, 2022

Signed-off-by: Ion Bazan ion.bazan@gmail.com

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

Provides support for true, false and null types.

The false and null ale no longer required to be a part of a union, therefore they can used on its own. The requiresUnionWithStandaloneType() method has been replaced with a simple return false as it is used in assertCanBeAStandaloneType() and assertCanIntersectWith() - it may be replaced in the future if needed.

See: #142

Signed-off-by: Ion Bazan <ion.bazan@gmail.com>
@IonBazan IonBazan force-pushed the feature/php8.2-types branch from 5806e8f to 764d869 Compare November 2, 2022 16:10
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @IonBazan!

@Ocramius Ocramius self-assigned this Nov 18, 2022
@Ocramius Ocramius added this to the 4.8.0 milestone Nov 18, 2022
@Ocramius Ocramius merged commit 0e714c2 into laminas:4.8.x Nov 18, 2022
@IonBazan IonBazan deleted the feature/php8.2-types branch November 18, 2022 11:21
@fezfez fezfez mentioned this pull request Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants