Skip to content

Use str_starts_with() and str_contains() where possible#158

Merged
Ocramius merged 1 commit intolaminas:4.8.xfrom
fezfez:small-impovement
Nov 21, 2022
Merged

Use str_starts_with() and str_contains() where possible#158
Ocramius merged 1 commit intolaminas:4.8.xfrom
fezfez:small-impovement

Conversation

@fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 21, 2022

No description provided.

@Ocramius Ocramius self-assigned this Nov 21, 2022
@Ocramius Ocramius added this to the 4.8.0 milestone Nov 21, 2022
@Ocramius
Copy link
Member

Error: src/Generator/ValueGenerator.php:315:46: MixedArgument: Argument 2 of str_contains cannot be mixed, expecting string (see https://psalm.dev/030)

Unsure if it should go to baseline or not.

Signed-off-by: Stéphane Demonchaux <demonchaux.stephane@gmail.com>
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fezfez!

@Ocramius Ocramius merged commit eb0cb01 into laminas:4.8.x Nov 21, 2022
@Ocramius Ocramius changed the title Use str_starts_with and str_contains where possible Use str_starts_with() and str_contains() where possible Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants