Make the return-type of ClassReflection#getStartLine() explicit#161
Merged
Ocramius merged 1 commit intolaminas:4.8.xfrom Nov 25, 2022
Merged
Make the return-type of ClassReflection#getStartLine() explicit#161Ocramius merged 1 commit intolaminas:4.8.xfrom
ClassReflection#getStartLine() explicit#161Ocramius merged 1 commit intolaminas:4.8.xfrom
Conversation
This was removed in laminas#154 but this phpdoc is useful to some static analyzers, so that they can know what the future return-type is going to be. Signed-off-by: Nicolas Grekas <nicolas.grekas@gmail.com>
Ocramius
requested changes
Nov 25, 2022
Contributor
|
If we are aiming for |
Member
|
@IonBazan changing a return type in a non- |
Ocramius
changed the title
ClassReflection#getStartLine() explicit
Contributor
|
Noted, let's do that for v5, if you don't mind |
Member
|
@IonBazan I'd be really happy to make a lot of this stuff Once it's |
Contributor
Author
|
Thanks for merging quickly! |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was removed in #154 but this phpdoc is useful to some static analyzers, so that they can know what the future return-type is going to be.