Fix “Unsafe usage of new static()” by making EmptyResponse final#216
Open
arshidkv12 wants to merge 1 commit intolaminas:3.7.xfrom
Open
Fix “Unsafe usage of new static()” by making EmptyResponse final#216arshidkv12 wants to merge 1 commit intolaminas:3.7.xfrom
arshidkv12 wants to merge 1 commit intolaminas:3.7.xfrom
Conversation
Signed-off-by: Arshid <arshidkv12@gmail.com>
Member
|
This is bc break, can't land in minor version. There should be no child for this class, extends parent Response instead. If needed, use so no bc break, while inform user to not extends it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marking EmptyResponse as final prevents late static binding issues
when instantiating with
new static(), ensuring type safety andavoiding potential runtime errors in subclasses.
Description
Marking EmptyResponse as final prevents late static binding issues
when instantiating with
new static(), ensuring type safety andavoiding potential runtime errors in subclasses.