Skip to content

Set the DOM encoding to UTF-8 when it is not specified in a feed's xml declaration#114

Closed
bramley wants to merge 1 commit intolaminas:2.27.xfrom
bramley:no_encoding
Closed

Set the DOM encoding to UTF-8 when it is not specified in a feed's xml declaration#114
bramley wants to merge 1 commit intolaminas:2.27.xfrom
bramley:no_encoding

Conversation

@bramley
Copy link
Contributor

@bramley bramley commented Feb 15, 2026

Q A
Documentation no
Bugfix yes
BC Break no
New Feature no
RFC no
QA no

Description

Fixes #112
The unit test in #113 now passes.

duncan@duncan-OptiPlex-990 ~/Development/GitHub/laminas-feed $ phpunit --group LaminasRATOMCONTENT
PHPUnit 9.5.10 by Sebastian Bergmann and contributors.

  Warning - The configuration file did not pass validation!
  The following problems have been detected:

  Line 16:
  - Element 'source': This element is not expected.

  Test results may not be as expected.


........                                                            8 / 8 (100%)

Time: 00:00.021, Memory: 36.28 MB

OK (8 tests, 8 assertions)

@froschdesign
Copy link
Member

@bramley
Please add the fix to #113, then we can see if it works in the checks.

@froschdesign
Copy link
Member

Superseded by #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fatal error when accessing a content element of type xhtml in an atom feed that doesn't have an explicit xml encoding

2 participants