feat remove abandoned laminas json with native php functions#80
Open
mairo744 wants to merge 2 commits intolaminas:4.0.xfrom
Open
feat remove abandoned laminas json with native php functions#80mairo744 wants to merge 2 commits intolaminas:4.0.xfrom
mairo744 wants to merge 2 commits intolaminas:4.0.xfrom
Conversation
Contributor
|
@froschdesign any news ? |
samsonasik
reviewed
Mar 10, 2026
Signed-off-by: mmalac <mmalac@sygic.com>
mairo744
force-pushed
the
chore/laminas-json
branch
from
67d734e to
91692e9
Compare
gsteel
requested changes
Mar 11, 2026
boesing
reviewed
Mar 11, 2026
…ntation - Replaced custom logic with native JSON functions, utilizing `JSON_UNESCAPED_UNICODE` and `JSON_UNESCAPED_SLASHES`. - Removed unsupported options such as `cycle_check` and `enable_json_expr_finder`. - Add tests for serialization and deserialization Signed-off-by: mmalac <mmalac@sygic.com>
mairo744
force-pushed
the
chore/laminas-json
branch
from
4276de3 to
0393267
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change removes all usage of
Laminas\Jsonin favor of PHP’s nativejson_encode()andjson_decode()functions.Reason for change:
laminas/laminas-jsonis abandoned and no longer maintained.Changes made:
LaminasJson::encode()calls withjson_encode()usingJSON_THROW_ON_ERROR.LaminasJson::decode()calls withjson_decode()and$associativemapping from the configured object decode type.Impact:
laminas/laminas-jsonpackage.JsonExceptionfrom PHP core), but they are wrapped to maintain public API compatibility.