Draft
Conversation
Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
specifically add WrappingObjectStor so we can add addtional parameters to a custom object store Fixes: lancedb#22 Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com>
the example is using an existing s3 object store and pass the arguments via the user_data opaque pointer (same parameters could be passed using the key/value map of strings) Signed-off-by: Yuval Lifshitz <ylifshit@ibm.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@soumyakoduri could you please review and verify that this PR satisfy your need with the custom storage class?