Draft
Conversation
Signed-off-by: 9401adarsh <dev.9401adarsh@gmail.com>
Author
|
Hi @yuvalif, have started work on the issue. Please have a look and let me know your thoughts. |
yuvalif
reviewed
Mar 9, 2026
| REQUIRE(builder != nullptr); | ||
| builder = lancedb_connect_builder_storage_option(builder, "hello", "world"); | ||
| REQUIRE(builder != nullptr); | ||
| builder = lancedb_connect_builder_session(builder, nullptr); |
Collaborator
There was a problem hiding this comment.
this is tested in line 77. why do you need it here?
Author
There was a problem hiding this comment.
I wanted to check for operator chaining, i.e if i am able to both storage option and session with the same object - as the original SDK allows for it.
Will drop it if you fell this isn't needed.
Collaborator
There was a problem hiding this comment.
you are right. keep this test
Collaborator
|
as discussed, please add the following tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #17.
What's been implemented?
src/connection.rs.include/lancedb.h.tests/test_connection.cpp.docs/index.rst.To-Discuss and Pending Items: