Skip to content

chore: bump deps and pass rust 1.86 warnings#12

Merged
eddyxu merged 1 commit intomainfrom
lei/bump_rust
Apr 4, 2025
Merged

chore: bump deps and pass rust 1.86 warnings#12
eddyxu merged 1 commit intomainfrom
lei/bump_rust

Conversation

@eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Apr 4, 2025

No description provided.

@eddyxu eddyxu requested review from chebbyChefNEQ and Copilot April 4, 2025 05:01
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/memory.rs:103

  • Verify that using RefreshKind::nothing() still provides all required default refresh behaviors compared to the previous RefreshKind::new(), to avoid unintended omissions in system metrics.
RefreshKind::nothing().with_memory(MemoryRefreshKind::everything()),

.github/workflows/rust.yml:29

  • Confirm that the removal of the explicit toolchain version is intentional and that the CI environment defaults to the desired Rust 1.86 version without issues.
-          toolchain: 1.83

.github/workflows/rust.yml:56

  • Ensure that updating the macOS runner from version 14 to 15 is compatible with all CI steps and does not introduce environmental inconsistencies.
runs-on: macos-15

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 57.79%. Comparing base (ab9651b) to head (88f6720).

Files with missing lines Patch % Lines
src/memory.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   57.79%   57.79%           
=======================================
  Files           4        4           
  Lines         481      481           
  Branches      481      481           
=======================================
  Hits          278      278           
  Misses        194      194           
  Partials        9        9           
Flag Coverage Δ
unittests 57.79% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eddyxu eddyxu requested a review from wkalt April 4, 2025 16:56
@eddyxu eddyxu merged commit 6e55ab6 into main Apr 4, 2025
3 checks passed
@eddyxu eddyxu deleted the lei/bump_rust branch April 4, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants