Skip to content

chore: upgrade object store crate#14

Open
eddyxu wants to merge 2 commits intomainfrom
lei/upgrade_os
Open

chore: upgrade object store crate#14
eddyxu wants to merge 2 commits intomainfrom
lei/upgrade_os

Conversation

@eddyxu
Copy link
Contributor

@eddyxu eddyxu commented Sep 29, 2025

No description provided.

@eddyxu eddyxu requested a review from Copilot September 29, 2025 18:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request upgrades the object_store crate from version 0.11 to 0.12, along with other dependency updates. The changes primarily involve adapting the codebase to the new API where range parameters have changed from Range<usize> to Range<u64>.

  • Updates object_store dependency from 0.11 to 0.12
  • Adapts range handling to use u64 instead of usize throughout the codebase
  • Updates other dependencies including sysinfo and criterion

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
Cargo.toml Updates dependency versions for object_store, sysinfo, and criterion
src/read_through.rs Adapts range handling from usize to u64, adds type conversions and error handling
src/memory.rs Updates test code to use u64 ranges for get_range calls
benches/memory.rs Updates benchmark code to use u64 ranges with proper type conversions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.31%. Comparing base (6e55ab6) to head (0d84db4).

Files with missing lines Patch % Lines
src/read_through.rs 68.29% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #14      +/-   ##
==========================================
- Coverage   57.79%   56.31%   -1.48%     
==========================================
  Files           4        4              
  Lines         481      467      -14     
  Branches      481      467      -14     
==========================================
- Hits          278      263      -15     
- Misses        194      199       +5     
+ Partials        9        5       -4     
Flag Coverage Δ
unittests 56.31% <70.45%> (-1.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants