Fix zombie processes generation#599
Open
KarenBarsegyan wants to merge 1 commit intolandley:masterfrom
Open
Conversation
run_script function logic: forked process goes into if(!pid) and starts external script. After executing the script, process ends right after execvp and parent process continues working. It has to go to if(error) by origin logic, but it doesn't. Therefore waitpid isn't called and forked process lives in Z state until dhcp client stops. This bug leads to infinite spawning of Z processes. Therefore, just call waitpid in any case, not only error. And only after waitpid is done, check error code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_script function logic: forked process goes into if(!pid) and starts external script. After executing the script, process ends right after execvp and parent process continues working. It has to go to if(error) by origin logic, but it doesn't. Therefore waitpid isn't called and forked process lives in Z state until dhcp client stops.
This bug leads to infinite spawning of Z processes. Therefore, just call waitpid in any case, not only error. And only after waitpid is done, check error code.