feat: promote npm edge tag to latest when prerelease is promoted#83
Merged
AaronFeledy merged 1 commit intomainfrom Feb 20, 2026
Merged
feat: promote npm edge tag to latest when prerelease is promoted#83AaronFeledy merged 1 commit intomainfrom
AaronFeledy merged 1 commit intomainfrom
Conversation
Adds a 'released' trigger to the release workflow with a lightweight 'promote' job that runs npm dist-tag to move 'latest' to the current version when a prerelease is promoted to a full release. The existing publish pipeline remains gated to 'published' events only.
| echo "::notice title=Promoted $VERSION to latest::The latest tag now points to $VERSION (was edge-only)" | ||
| env: | ||
| TAG_NAME: ${{ github.event.release.tag_name }} | ||
| NODE_AUTH_TOKEN: ${{secrets.NPM_DEPLOY_TOKEN}} |
There was a problem hiding this comment.
Promote job fails on fresh non-prerelease publishes
Medium Severity
When a fresh (non-prerelease) release is published, GitHub fires both published and released events, triggering two separate workflow runs. The promote job (~30s) will complete long before the deploy job (~5-10min) finishes publishing to npm. Since the version doesn't exist on the registry yet, npm dist-tag add will fail, causing a red X on every non-prerelease publish. The PR description claims "the redundant promote is harmless," but the race condition means it errors rather than succeeding idempotently.
Additional Locations (1)
✅ Deploy Preview for lando-symfony ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
When a release is published as a prerelease, it gets tagged as
edgeon npm. Later, when the release is promoted to a full release in GitHub, the npmlatesttag doesn't update because the workflow only triggered onpublished.Solution
releasedto the release workflow trigger typespromotejob that only runsnpm dist-tag add latest— no install, no lint, no tests, no re-publishreleasedevent (when a prerelease is promoted to full release)deployjob is now explicitly gated topublishedevents only (no behavior change)TAG_NAMEenv var instead of direct interpolation to prevent script injectionFlow
edgetag (unchanged)promotejob runs, pointslatestto that version (~15s)The
dist-tag addcommand is idempotent, so if bothpublishedandreleasedfire on a fresh non-prerelease publish, the redundant promote is harmless.Note
Low Risk
Workflow-only change that adjusts npm dist-tags and job triggering; low code risk, but could affect release automation if misconfigured.
Overview
Updates the
release.ymlworkflow to also run on GitHubreleaseevents of typereleased, and adds a newpromotejob that runs only forreleasedactions to move npmlatestto the promoted version vianpm dist-tag add.Gates the existing
deployjob to run only onpublishedactions, avoiding re-running the publish pipeline during promotions.Written by Cursor Bugbot for commit abd81f5. This will update automatically on new commits. Configure here.