fix(tools): enforce returning Command object in writeTodos for graph state updates#15
Merged
Palash Shah (Palashio) merged 1 commit intolangchain-ai:mainfrom Aug 22, 2025
Conversation
Collaborator
|
hey! taking a look at this, thank you! |
Palash Shah (Palashio)
approved these changes
Aug 22, 2025
Christian Bromann (christian-bromann)
added a commit
that referenced
this pull request
Feb 2, 2026
When two tools are called in parallel and one is interrupted via interruptOn, rejecting the interrupt would leave a dangling tool_call_id, causing the provider to throw a 400 error. The root cause was middleware ordering: createPatchToolCallsMiddleware ran before humanInTheLoopMiddleware, so the dangling tool call patch could be overwritten when HITL processed the reject decision. Fix by moving createPatchToolCallsMiddleware to run after humanInTheLoopMiddleware, ensuring it can properly patch any remaining dangling tool calls after HITL has processed resume decisions. Fixes #15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the inconsistency in the writeTodos tool implementation, which currently returns a plain object rather than the documented Command object.
Please refer #14 for more information.