-
Notifications
You must be signed in to change notification settings - Fork 0
LangGraph migration #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lnhsingh
wants to merge
19
commits into
main
Choose a base branch
from
migrate-lg
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
LangGraph migration #109
+35,543
−378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Preview link: https://langchain-5e9cc07a-preview-brodyd-1754925111-e44a21e.mintlify.app/oss/python/overview This PR does two main things: 1. It reworks the `builder.py` file to generate JS and Python versions of the docs. 2. It adds CSS and JS files for conditionally hiding the language picker. The requirements for the picker are: - Show the picker when viewing the LangGraph docs - Hide the picker when viewing the LangGraph Platform or LangChain Labs docs ## Review requests + info We're doing custom things on top of Mintlify's stuff. It would be great if someone can help verify the changes to the `builder.py` file are acceptable, and although it's not the most elegant solution, that the CSS and JS files are an acceptable though likely temporary solution. I tried to update and fix tests appropriately but I really need someone to validate those changes are good. I haven't fixed/updated unit tests like this before. ## Todos - [x] Get this PR reviewed and implement any feedback - [x] Fix tests - [ ] Merge with #109 - [ ] 🎉 --------- Co-authored-by: Lauren Hirata Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.