Skip to content

fix: Return ChatBedrockConverse streaming content as str instead of list #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 21, 2025
Merged

fix: Return ChatBedrockConverse streaming content as str instead of list #589

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e071fbc
fix(bedrock): return string content in ChatBedrockConverse streaming
SYED-M-HUSSAIN May 26, 2025
740e246
fixing the standard integration tests in PR-491
SYED-M-HUSSAIN May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions libs/aws/langchain_aws/chat_models/bedrock_converse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,7 +1189,10 @@ def _parse_stream_event(event: Dict[str, Any]) -> Optional[BaseMessageChunk]:
index=event["contentBlockStart"]["contentBlockIndex"],
)
)
return AIMessageChunk(content=[block], tool_call_chunks=tool_call_chunks)
# always keep block inside a list to preserve merging compatibility
content = [block]

return AIMessageChunk(content=content, tool_call_chunks=tool_call_chunks)
elif "contentBlockDelta" in event:
block = {
**_bedrock_to_lc([event["contentBlockDelta"]["delta"]])[0],
Expand All @@ -1205,19 +1208,20 @@ def _parse_stream_event(event: Dict[str, Any]) -> Optional[BaseMessageChunk]:
index=event["contentBlockDelta"]["contentBlockIndex"],
)
)
return AIMessageChunk(content=[block], tool_call_chunks=tool_call_chunks)
# always keep block inside a list to preserve merging compatibility
content = [block]

return AIMessageChunk(content=content, tool_call_chunks=tool_call_chunks)
elif "contentBlockStop" in event:
# TODO: needed?
return AIMessageChunk(
content=[{"index": event["contentBlockStop"]["contentBlockIndex"]}]
)
return AIMessageChunk(content=[])
elif "messageStop" in event:
# TODO: snake case response metadata?
return AIMessageChunk(content=[], response_metadata=event["messageStop"])
return AIMessageChunk(content="", response_metadata=event["messageStop"])
elif "metadata" in event:
usage = _extract_usage_metadata(event["metadata"])
return AIMessageChunk(
content=[], response_metadata=event["metadata"], usage_metadata=usage
content="", response_metadata=event["metadata"], usage_metadata=usage
)
elif "Exception" in list(event.keys())[0]:
name, info = list(event.items())[0]
Expand Down
2 changes: 1 addition & 1 deletion libs/aws/tests/integration_tests/chat_models/test_bedrock_converse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,7 +455,7 @@ def test_structured_output_thinking_force_tool_use() -> None:
},
}
with pytest.raises(llm.client.exceptions.ValidationException):
response = llm.client.converse(messages=messages, **params)
llm.client.converse(messages=messages, **params)


def test_bedrock_pdf_inputs() -> None:
Expand Down